@remotion/lambda: Handle concurrency being undefined
#6035
Closed
+3
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR handles the case where the PHP Lambda client omits the concurrency parameter when calling the serverless start handler, allowing it to be undefined in addition to number | null.
Key changes:
- Updated the
ServerlessStartPayloadtype to allowconcurrencyto benumber | null | undefined - Used the nullish coalescing operator to convert
undefinedtonullwhen creating the launch payload
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
packages/serverless-client/src/constants.ts |
Added undefined to the concurrency type in ServerlessStartPayload with a comment explaining the PHP Lambda client behavior |
packages/serverless/src/handlers/start.ts |
Used nullish coalescing operator to convert undefined concurrency to null before passing to launch payload |
Member
Author
|
I got no response on Discord, so I have to assume user just didn't update their Lambda SDK. Closing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only merge if https://discord.com/channels/809501355504959528/844143007183667220/1447661945003184178 turns out to not be true