Skip to content

Commit

Permalink
Fix missing returns in repositories and handlers
Browse files Browse the repository at this point in the history
Found by new, strictier PHPStan. Fixed issues:

- Method Crm\PaymentsModule\Repository\PaymentGatewaysRepository::update()
  should return bool but return statement is missing.
- Method Crm\ScenariosModule\Repository\TriggersRepository::delete()
  should return bool but return statement is missing.
- Method Crm\ScenariosModule\Repository\ElementsRepository::delete()
  should return bool but return statement is missing.
- Method Crm\UsersModule\Repository\UsersRepository::update()
  should return bool but return statement is missing.

- Method Crm\SurveyHeroModule\Api\SurveyHeroWebhookHandler::params()
  should return array<Crm\ApiModule\Params\ParamInterface> but return
  statement is missing.
- Method Crm\StripeModule\Api\SetupIntentHandler::params()
  should return array<Crm\ApiModule\Params\ParamInterface> but return
  statement is missing.

remp/crm#2007
  • Loading branch information
markoph committed Sep 16, 2021
1 parent 202b2e1 commit a426f69
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions src/api/SetupIntentHandler.php
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ public function __construct(StripeRecurrent $stripe)

public function params()
{
return [];
}

public function handle(ApiAuthorizationInterface $authorization)
Expand Down

0 comments on commit a426f69

Please sign in to comment.