Skip to content

Commit

Permalink
Move system settings configuration to Beam module
Browse files Browse the repository at this point in the history
The settings were not propagated to the Skeleton and
were ignored by the Skeleton apps. This could cause
schedule commands not being execute due to "notOverlapping"
flags, which were written to the Redis correctly.

remp/remp#1292

(cherry picked from commit 3c20164)
  • Loading branch information
rootpd committed Aug 11, 2023
1 parent 1704b51 commit 106daf1
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 0 deletions.
File renamed without changes.
1 change: 1 addition & 0 deletions Beam/extensions/beam-module/src/BeamServiceProvider.php
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,7 @@ public function boot()
__DIR__ . '/../public/' => public_path('vendor/beam'),
__DIR__ .'/../config/beam.php' => config_path('beam.php'),
__DIR__ .'/../config/services.php' => config_path('services.remp.php'),
__DIR__ .'/../config/system.php' => config_path('system.php'),
], ['beam-assets', 'laravel-assets']
);

Expand Down
4 changes: 4 additions & 0 deletions changelogs/CHANGELOG-v3.1.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
## [3.1] - 2023-07-24

- [3.1.1] [Campaign]: Changed `asset()` function in `showtime.php` to return absolute URL. remp/remp#1282
- [3.1.2] [Beam]: Fixed schedules not being registered for Skeleton application. remp/remp#1292
- [3.1.2] [Beam]: Fixed commands not being available to execute for synchronous web event handlers. remp/remp#1292
- [3.1.2] [Beam]: Refactored system settings configuration so they're available within Beam module and for Skeleton apps. remp/remp#1292

### [Beam]

Expand Down Expand Up @@ -28,6 +31,7 @@
---

[3.1.1]: https://github.com/remp2020/remp/compare/3.1.0...3.1.1
[3.1.2]: https://github.com/remp2020/remp/compare/3.1.1...3.1.2

[Beam]: https://github.com/remp2020/remp/tree/master/Beam
[Campaign]: https://github.com/remp2020/remp/tree/master/Campaign
Expand Down

0 comments on commit 106daf1

Please sign in to comment.