Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements from fork #11

Merged
merged 3 commits into from
Dec 11, 2024
Merged

Improvements from fork #11

merged 3 commits into from
Dec 11, 2024

Conversation

remram44
Copy link
Owner

@mrd0ll4r I see you have made improvements in your fork. I don't know if you intend to contribute those new algorithms to this repo (or if you are ready to do so) but I would grab the doc and SizeLimited improvements if that's ok.

@mrd0ll4r
Copy link
Contributor

Oh, nice! Of course, do grab those! I think most of the algorithms we added on our side are also ready to be included. Some of them are experimental and we tried different implementations. For those, we're still evaluating which implementations perform best.
I think everything apart from BFBC should be fine.

To pull them into here, I probably have to rewrite history on our end a bit to separate the two into different commits...
On the other hand, I see that you somehow cherry-picked multiple things from that one commit I made, and it even preserved authorship somehow. How did you do that?

@remram44
Copy link
Owner Author

I used git rebase --interactive to do this. I am going to merge this, feel free to send a pull request for the new algorithms whenever you are ready.

Thanks!

@remram44 remram44 merged commit 4e08faa into master Dec 11, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants