Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable lean tests that were skipped, but are now passing #1109

Closed
wants to merge 1 commit into from
Closed

Re-enable lean tests that were skipped, but are now passing #1109

wants to merge 1 commit into from

Conversation

protoben
Copy link
Collaborator

@protoben protoben commented Mar 6, 2025

8 tests that were skipped in test/lean/run_tests.py are now passing. This re-enables them.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 6, 2025

Test Results

   13 files     29 suites   0s ⏱️
  854 tests   854 ✅ 0 💤 0 ❌
3 619 runs  3 619 ✅ 0 💤 0 ❌

Results for commit 23a74e4.

@tobiasgrosser
Copy link
Collaborator

tobiasgrosser commented Mar 6, 2025 •
edited
Loading

@protoben, thank you for your contribution. These are precisely the kind of patches we need. @Alasdair has pushed the particular change you propose in 2f45fe5 / #1107, parallel to submitting your PR. So this PR can probably be closed. However, please continue these kind of PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@protoben @tobiasgrosser