feat: improve signal handling with timeout and better POSIX compliance (#1705) #2263
+167
−16
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements the signal handling improvements proposed in #1705 for better POSIX compliance and systemd compatibility.
Changes
Breaking Changes
SIGUSR2toSIGHUPApplications listening for
SIGUSR2should either:SIGHUP(recommended), or--signal SIGUSR2in nodemon configurationMigration Example
Implementation Details
New
killWithTimeout()FunctionAdded a new function that implements graceful shutdown with timeout-based escalation:
Signal Handler Improvements
SIGINT (Ctrl+C):
SIGTERM:
killTimeoutTimeoutStopSecSIGQUIT (new):
SIGHUP (new):
Testing
Manual testing has been performed for:
Backward Compatibility
Users can maintain the old behavior by explicitly setting
signal: 'SIGUSR2'in their configuration:Or in
nodemon.json:{ \"signal\": \"SIGUSR2\" }Related Issues
Fixes #1705
Related to #1667, #1661
Checklist