Add simple validation to the philosophers benchmark #446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lbulej
force-pushed
the
topic/philosophers-validation
branch
from
5b9f32a
to
4d8e9a8
Compare
Signed-off-by: BohdanQQ <40754203+BohdanQQ@users.noreply.github.com> Validate 'meals eaten' in the philosophers benchmark
Forks should not be owned by anyone and the philosophers should have consumed the expected number of meals. Also removes the extraneous run method.
lbulej
force-pushed
the
topic/philosophers-validation
branch
from
4d8e9a8
to
f0ffa52
Compare
|
Rebased to master after merging #444. |
axel22
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This started as a simple hash-based validation @BohdanQQ's fork from which I cherry-picked bits. Because there is no reason to validate hash of the output when we have the actual values, I modified the validation to validate the number of meals eaten directly and added an extra check that the forks have no owner at the end.