Update SBT to version 1.9.9 and buildenv images and JDK versions in CI #450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The scripts should download the necessary binaries into local cache. The binaries were meant to make it easier to use the repository in disconnected mode, but such a use case is rather unlikely, because building the project without being able to download dependencies is doomed to fail, unless all dependencies were cached. Keeping the launcher scripts allows building the repository without SBT installed, otherwise people should just use their system-wide SBT.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Picks elements from #443 and adds a few related updates.
After some consideration, we actually drop the SBT binaries because the use case they were meant for (building Renaissance in a networkless environment) does not seem to make much sense given the amount of dependencies that need to be downloaded.
The CI was updated to use version 10 of
buildenvimages and the JDK versions tested were bumped to 22 (latest), { 11, 17, 21 } (legacy), and 23 (EA).