Fail also when given string is not a valid number#2
Open
bitboxer wants to merge 2 commits intorenanvy:masterfrom
Open
Fail also when given string is not a valid number#2bitboxer wants to merge 2 commits intorenanvy:masterfrom
bitboxer wants to merge 2 commits intorenanvy:masterfrom
Conversation
Also updates all packages and fixes a compiler warning on modern elixir
|
It would be great to have this merged tbh. |
Author
|
@renanvy I can totally understand if you don't have time/energy to continue maintaining this. I hope you will be okay if I fork it in a couple of weeks and create a maintained version again. I need this for my little side project :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also updates all packages and fixes a compiler warning on modern elixir
Fixes #1