-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apec model status #111
Comments
Hi Nicolas, First, thank you for your feedback! As you may have seen, this package is very much WIP at this point, and we plan to release it to the community in ~2 months. You are welcome to use it though, just be aware that there will be many API changes and that the doc is a bit outdated already! Then, the APEC model is planned to be released at the same time. The implementation you can see is WIP, and I am not even sure it is working properly. At this time, we plan to use the compressed continuum, pseudo continuum and lines provided by AtomDB and that are used in XSPEC as a base for interpolating the flux of various elements and lines etc… This is very challenging to obtain a differentiable implementation of APEC with this approach, since the provided tables are given with various shapes, sparsely sampled in energies and different from an element to another. This is very JAX-unfriendly. @MolinAlexei succeeded in implementing a version that interpolate every continuum/pseudo continuum on the energy grid related to the instrument/observation, which I have to thoroughly test against XSPEC's. I am also closely following JAX future releases which might implement some ragged array stuff which would be perfect for this problem (see #16324, #16072). You are very welcome to share your idea about this topic, and also very welcome to contribute! Meanwhile, I will share updates on this issue. You can expect a functional APEC in ~2 months (at least I hope so!) |
Thanks for the detailed answer ! great, well I'd be glad to help on this if you need, I have experience with Xspec, pyatomdb and Jax ;) |
@nicolas-cerardi we are starting to work on the APEC model in a dedicated branch. I think we will use this issue to summarize the ongoing work. Since you're experienced with pyatomdb, could you help me with some questions ?
I am really struggling with the interpolated approach right now, and start thinking it might just be better to rewrite it from ground in pure JAX instead of dealing with the compressed interpolated tables |
Hi, what is the current status of the apec model ?
I saw it in the source code, but not in the docs, is it work in progress ?
Related, the source redshift looks to be missing in the apec implementation.
...overall, congrats for this very nice package !
The text was updated successfully, but these errors were encountered: