-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(config/inherit): resolve presets #31642
base: main
Are you sure you want to change the base?
Changes from 6 commits
9d1a597
6208ad1
9e2f462
a52e9b9
140a794
2fff2f1
2a932d5
712f3d7
b01e062
139fced
716c1a6
d697f48
8786fba
e871e4f
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||||||
---|---|---|---|---|---|---|---|---|---|---|
|
@@ -155,6 +155,17 @@ Inherited config may use all Repository config settings, and any Global config o | |||||||||
|
||||||||||
For information on how the Mend Renovate App supports Inherited config, see the dedicated "Mend Renovate App Config" section toward the end of this page. | ||||||||||
|
||||||||||
#### Presets handling | ||||||||||
|
||||||||||
If the inherited config has presets, then Renovate: | ||||||||||
|
||||||||||
1. Resolves the presets | ||||||||||
1. Adds the resolved presets to the inherited config | ||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
Maybe this is better. If we go with |
||||||||||
1. Merges the presets on top of the global config | ||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||||
|
||||||||||
RahulGautamSingh marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||||||
Using `ignorePresets` in your repository config to ignore certain presets will _not_ affect presets present in the inherited config. | ||||||||||
RahulGautamSingh marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||||||
This is because inherited config is resolved _before_ the repository config. | ||||||||||
|
||||||||||
### Repository config | ||||||||||
|
||||||||||
Repository config is the config loaded from a config file in the repository. | ||||||||||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.