New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tracky Refactoring #142

Merged

CuddlyBunion341 merged 55 commits into main from feature/19656-improve-tracky

Jun 26, 2024

Contributor

CuddlyBunion341 commented May 24, 2024 •

edited

Loading

The goal is to improve tracky by refactoring existing code and updating the UI.
The main concern on the Plugin is the session management and the ocassionally useless abstractions.

Doc: https://docs.google.com/document/d/1BCTawEQqfiAzCoRx3yih0WRGDkOl_HR8Em61sTzzOds/edit#heading=h.nkew4uhlsarb

Updated Layout (without hints)

CuddlyBunion341 added 6 commits

May 23, 2024 15:40


          Replace current_user with User.current

9847b9b


          Remove permission manager

174c912


          Remove current user

c0b4811


          Rename validations

6f679a3


          Refactor timer duration


          Implement upsert action

77faf73

CuddlyBunion341 self-assigned this

CuddlyBunion341 added 2 commits

May 24, 2024 08:56


          Fix linter

3810c36


          Rename tracker route

7ec3cd4

CuddlyBunion341 commented

View reviewed changes

app/components/timer_session_entry_component.rb Show resolved Hide resolved

CuddlyBunion341 commented

View reviewed changes

app/controllers/time_tracker_controller.rb Outdated Show resolved Hide resolved

CuddlyBunion341 commented

View reviewed changes

app/controllers/time_tracker_controller.rb Outdated Show resolved Hide resolved

CuddlyBunion341 commented

View reviewed changes

app/controllers/time_tracker_controller.rb Show resolved Hide resolved

CuddlyBunion341 commented

View reviewed changes

app/controllers/time_tracker_controller.rb Outdated Show resolved Hide resolved

CuddlyBunion341 commented

View reviewed changes

app/controllers/time_tracker_controller.rb Outdated Show resolved Hide resolved

CuddlyBunion341 commented

View reviewed changes

app/controllers/time_tracker_controller.rb Outdated Show resolved Hide resolved

CuddlyBunion341 commented

View reviewed changes

app/models/timer_session.rb Outdated Show resolved Hide resolved

CuddlyBunion341 commented

View reviewed changes

app/views/shared/_js_variables.html.erb Outdated Show resolved Hide resolved

CuddlyBunion341 commented

View reviewed changes

assets.src/src/redmine-tracky/controllers/timer-controller.ts Outdated Show resolved Hide resolved

CuddlyBunion341 commented

View reviewed changes

assets/javascripts/redmine-tracky.js Outdated Show resolved Hide resolved

CuddlyBunion341 commented

View reviewed changes

config/routes.rb Outdated Show resolved Hide resolved

CuddlyBunion341 commented

View reviewed changes

app/views/timer_sessions/_timer_container.html.erb Outdated Show resolved Hide resolved

CuddlyBunion341 force-pushed the feature/19656-improve-tracky branch from 76a1eb6 to 7270c5e Compare

June 7, 2024 09:49

CuddlyBunion341 added 7 commits

June 7, 2024 11:50


          Update frontend tracky layout

9b3a382

Refactor frontend


          Rename updateTimer to updateTimerLabel

2edb61c


          Refactor rename upsert to create_or_update

2ecc33b


          Update cancel param presence check

3c14cd4


          Remove unnecessary return statement

8c025c8


          Update cancel timer action

d4e8aca


          Refactor timer session enough_time

af1402e

CuddlyBunion341 added 8 commits

June 12, 2024 15:42


          Refactor time tracker

73361d3


          Refactor routes, specs

a2d3f8e


          Fix unit tests

b0d338d


          Attempt fix

1b9e79c


          Extract validators

bbc9a02


          Add record instance variable to validator

ce47040


          Remove missing method call

92e658e


          Move validators

df02314

CuddlyBunion341 marked this pull request as draft

June 21, 2024 15:05

CuddlyBunion341 added 15 commits

June 21, 2024 17:37


          Fix non_system checks

655e6d2


          Fix linter

adc386f


          Refactor time_tracker route from put to patch

63c7365


          Refactor actions

b17d996


          Refactor

f0d0a3f


          Update offset time

1e6b5c4


          Fix timer sessions

bfe1b79


          Fix linter

f44bd21


          Fix route

853fb89


          Improve coverage

4c098c7


          Move validation

4fc2750


          Improve coverage, fix specs

c44266f


          Improve coverage

a49b45b


          Improve coverage

dbe7779


          Fix linter

086cb54

CuddlyBunion341 marked this pull request as ready for review

June 25, 2024 15:34

schmijos approved these changes

View reviewed changes

Member

schmijos left a comment

Looks good! Let's make sure we test this properly on develop.

app/models/finished_timer_session_validator.rb Outdated Show resolved Hide resolved

app/models/finished_timer_session_validator.rb Outdated Show resolved Hide resolved

app/models/unfinished_timer_session_validator.rb Outdated Show resolved Hide resolved


          Refactor unless to if, update early return

29c148e

CuddlyBunion341 merged commit 6ffa97e into main

1 check passed

CuddlyBunion341 deleted the feature/19656-improve-tracky branch

June 26, 2024 12:19

CuddlyBunion341 mentioned this pull request

Fix time tracker permissions #150

Merged

3 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet