Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: open legal links in new tab #3613

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

mrcattington
Copy link

@mrcattington mrcattington commented Jan 10, 2025

Description

Added legalLinksNewTab option to allow Terms and Privacy Policy links to optionally open in new tabs.

Changes:

  • Added new optional configuration option legalLinksNewTab
  • When enabled, legal links open in new tabs with proper security attributes
  • Maintains backward compatibility by defaulting to current behavior

This improves UX by giving developers the choice of whether legal links should open in the same tab or a new tab.

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Associated Issues

For Linear issues: Closes APKT-xxx
For GH issues: closes #...

Showcase (Optional)

If there is a UI change include the screenshots with before and after state.
If new feature is being introduced, include the link to demo recording.

Checklist

  • Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • My changes generate no new warnings
  • I have reviewed my own code
  • I have filled out all required sections
  • I have tested my changes on the preview link
  • Approver of this PR confirms that the changes are tested on the preview link

Copy link

vercel bot commented Jan 10, 2025

@mrcattington is attempting to deploy a commit to the Reown Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

changeset-bot bot commented Jan 10, 2025

🦋 Changeset detected

Latest commit: 2f0e214

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 14 packages
Name Type
@reown/appkit-scaffold-ui Minor
@reown/appkit-core Minor
@reown/appkit-adapter-ethers Patch
@reown/appkit-adapter-ethers5 Patch
@reown/appkit-adapter-solana Patch
@reown/appkit-adapter-wagmi Patch
@reown/appkit Patch
@reown/appkit-adapter-bitcoin Patch
@reown/appkit-utils Patch
@reown/appkit-siwe Patch
@reown/appkit-siwx Patch
@reown/appkit-wallet-button Patch
@reown/appkit-experimental Patch
@reown/appkit-cdn Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@arein arein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently it opens in the same window? that's a bug to me - should just change the default behavior?

apps/laboratory/.env.example Outdated Show resolved Hide resolved
Co-authored-by: Derek <alexanderderekrein@gmail.com>
@mrcattington
Copy link
Author

I've updated the code to make opening links in new tabs the default behavior instead of having it as an optional configuration, and removed all the optional flag code. I've also reverted the project ID in the .env.example file.

@mrcattington mrcattington force-pushed the feat/legal-links-new-tab branch from e7297b9 to 2f0e214 Compare January 12, 2025 15:30
@mrcattington mrcattington changed the title feat: add optional new tab behavior for legal links fix: add optional new tab behavior for legal links Jan 12, 2025
@mrcattington mrcattington changed the title fix: add optional new tab behavior for legal links fix: open legal links in new tab Jan 14, 2025
@mrcattington
Copy link
Author

Not trying to be annoying, just haven’t seen any movement on this in a while. I was hoping it would be included in the next release. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants