-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: open legal links in new tab #3613
base: main
Are you sure you want to change the base?
fix: open legal links in new tab #3613
Conversation
@mrcattington is attempting to deploy a commit to the Reown Team on Vercel. A member of the Team first needs to authorize it. |
🦋 Changeset detectedLatest commit: 2f0e214 The changes in this PR will be included in the next version bump. This PR includes changesets to release 14 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently it opens in the same window? that's a bug to me - should just change the default behavior?
Co-authored-by: Derek <alexanderderekrein@gmail.com>
I've updated the code to make opening links in new tabs the default behavior instead of having it as an optional configuration, and removed all the optional flag code. I've also reverted the project ID in the .env.example file. |
e7297b9
to
2f0e214
Compare
Not trying to be annoying, just haven’t seen any movement on this in a while. I was hoping it would be included in the next release. Thank you! |
Description
Added
legalLinksNewTab
option to allow Terms and Privacy Policy links to optionally open in new tabs.Changes:
legalLinksNewTab
This improves UX by giving developers the choice of whether legal links should open in the same tab or a new tab.
Type of change
Associated Issues
For Linear issues: Closes APKT-xxx
For GH issues: closes #...
Showcase (Optional)
If there is a UI change include the screenshots with before and after state.
If new feature is being introduced, include the link to demo recording.
Checklist