-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display matched selector priority #10609
Merged
Merged
+15
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Andarist
commented
Jul 10, 2024
@@ -10,12 +10,13 @@ interface DeclarationValueProps { | |||
colorSpanClassName: string; | |||
colorSwatchClassName: string; | |||
fontFamilySpanClassName: string; | |||
priority?: string; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are there places where we'd like to render this without the priority? Chrome doesn't render it in its Computed tab
Andarist
changed the title
Display matched selector priority @Andarist
Display matched selector priority
Jul 10, 2024
hbenl
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to the investigation that led to #10608 . We can see there that the non-top rule was originally left as the "matching one".
While it shouldn't even be displayed there in the first place (which got fixed by #10608 ), it wasn't apparent why it got matched. The specificity wasn't higher. It turns out that it was an
!important
rule but we never surfaced that in the UI.