Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Placeholder NUX for testsuites #9958

Closed
wants to merge 2 commits into from
Closed

Conversation

jonbell-lot23
Copy link
Contributor

@jonbell-lot23 jonbell-lot23 commented Dec 3, 2023

Summary

We're going to build something more engaging soon, but in the meantime we should at least link to our docs. I've added a new file called TestRunsNUX for us to build on more later.

(Note for later: I had trouble centering this content horizontally and vertically because the div stretches across the width of the page despite only being 1/3. We'll talk about that later)

Old:

image

New:

image

Copy link

vercel bot commented Dec 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
devtools ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 3, 2023 8:36pm

Copy link

replay-io bot commented Dec 3, 2023

E2E Tests

StatusComplete ↗︎
Commita63988a
Results
4 Failed
⚠️ 1 Flaky
88 Passed

Snapshot Tests

StatusComplete ↗︎
Commita63988a
Results
⚠️ 5 Flaky
  • should properly bucket properties for an overflowing array
  • should remember search results count per source
      locator.textContent: Timeout 5000ms exceeded.
      =========================== logs ===========================
      waiting for locator('[data-test-id="SearchResultsLabel"]')
      ============================================================
  • should render and inspect maps
  • should render and inspect regular expressions
      expect(received).not.toMatch(expected)
      Expected pattern: not /data-test-name=['"]Loader['"]/
      Received string:      "<span class=\"Expandable_ToggleButton__A_ESs \" data-test-name=\"ExpandablePreview\" role=\"button\" tabindex=\"0\"><span class=\"Expandable_ArrowExpanded__aFn6S\"><svg class=\"Expandable_ArrowIcon__60FPO \" viewBox=\"0 0 24 24\" fill=\"currentColor\"><path d=\"M0 0h24v24H0z\" fill=\"none\"></path><path d=\"M8 5v14l11-7z\"></path></svg></span><span class=\"KeyValueRenderer_KeyValue__U2_FT\" data-test-name=\"KeyValue\"><span class=\"shared_RegExp__vZhr6\">/abc[123]+/i</span></span></span><span class=\" Expandable_Children__Ks8AZ\" data-test-name=\"ExpandableChildren\"><div class=\" Loader_Loader__JFuYi\" data-test-name=\"Loader\">Loading…</div></span>"
  • should render and inspect sets
      expect(received).not.toMatch(expected)
      Expected pattern: not /data-test-name=['"]Loader['"]/
      Received string:      "<span class=\"Expandable_ToggleButton__A_ESs \" data-test-name=\"ExpandablePreview\" role=\"button\" tabindex=\"0\"><span class=\"Expandable_ArrowExpanded__aFn6S\"><svg class=\"Expandable_ArrowIcon__60FPO \" viewBox=\"0 0 24 24\" fill=\"currentColor\"><path d=\"M0 0h24v24H0z\" fill=\"none\"></path><path d=\"M8 5v14l11-7z\"></path></svg></span><span class=\"KeyValueRenderer_KeyValue__U2_FT\" data-test-name=\"KeyValue\">Set<span class=\"shared_ArrayLength__PGTCc\">(4)</span><span class=\"shared_ArrayPropertyList__bVSVB\"> [<span class=\"shared_Value__LIkPu\"><span class=\"shared_Number____Nnm\" data-test-name=\"ClientValue\">1</span><span class=\"shared_Separator__w6oGd\">, </span></span><span class=\"shared_Value__LIkPu\"><span class=\"shared_String__pS3ms\" data-test-name=\"ClientValue\">\"two\"</span><span class=\"shared_Separator__w6oGd\">, </span></span><span class=\"shared_Value__LIkPu\"><span class=\"shared_Boolean__of5ek\" data-test-name=\"ClientValue\">true</span><span class=\"shared_Separator__w6oGd\">, </span></span><span class=\"shared_Value__LIkPu\">Set<span class=\"shared_ArrayLength__PGTCc\">(0)</span></span>]</span></span></span><span class=\" Expandable_Children__Ks8AZ\" data-test-name=\"ExpandableChildren\"><div class=\" Loader_Loader__JFuYi\" data-test-name=\"Loader\">Loading…</div></span>"
95 Passed

Copy link

replay-delta bot commented Dec 3, 2023

Copy link
Contributor

@ryanjduffy ryanjduffy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bvaughn
Copy link
Contributor

bvaughn commented Dec 7, 2023

When this is ready for review, please tag me and other folks on FE.

@bvaughn bvaughn mentioned this pull request Dec 7, 2023
@jonbell-lot23
Copy link
Contributor Author

I had some trouble getting this working, so I filed a FE ticket asking for help: https://linear.app/replay/issue/FE-2123/add-a-loading-state-to-our-placeholder-nux

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants