-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Placeholder NUX for testsuites #9958
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm seeing a flash of the NUX screen before the test runs load in. I think we need to plumb a loading state through. See a couple comments in this replay:
When this is ready for review, please tag me and other folks on FE. |
I had some trouble getting this working, so I filed a FE ticket asking for help: https://linear.app/replay/issue/FE-2123/add-a-loading-state-to-our-placeholder-nux |
Summary
We're going to build something more engaging soon, but in the meantime we should at least link to our docs. I've added a new file called TestRunsNUX for us to build on more later.
(Note for later: I had trouble centering this content horizontally and vertically because the div stretches across the width of the page despite only being 1/3. We'll talk about that later)
Old:
New: