tensorrt-llm: 0.9 -> 0.10, triton: 2.42.0 -> 2.44.0 #50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yorickvP
changed the title
Remove the tensorrt_llm python script, since it confuses `maybe_download_tarball_with_pget`
Contributor
|
enable_trt_overlap is set to false in a lot of places, we will probably need to change that we should review the new configuration options as well |
Comment on lines
+375
to
+377
| if token == []: | ||
| continue | ||
|
|
Contributor
There was a problem hiding this comment.
was this discovered by testing? what is this?
Contributor
Author
There was a problem hiding this comment.
Good question, it was discovered by testing. EOS seems to have been replaced by []. Potentially related to tokenizer config?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Open questions:
enable_trt_overlapdisappeared and a whole bunch of cache options got added.