Add support for historical data #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christian Holm <cho@cubitech.dk>
Signed-off-by: Christian Holm <cho@cubitech.dk>
|
Thanks for the PR @holm! Will give it a review this weekend 👍 |
|
I actually ended up doing some larger changes for our needs, but it ended up being fairly subjective and maybe not quite general purpose. All the changes are at https://github.com/normative-io/currency-codes-ts if you are curious. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for downloading and using historical currency codes.
I am not entirely sure if this is valuable in general, but since we needed the option, I thought I could take a stab at making this generally available.