Add ability to provide pre-defined secret for service-api and service-authorization #470
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raikbitters
reviewed
May 15, 2025
Member
raikbitters
left a comment
raikbitters
left a comment
There was a problem hiding this comment.
I don't like naming serviceapi-user-supplied-secret. Add more specific prefix like reportportal or return template name.
Author
The prefix reportportal prefix is added via some of the string interpolation included |
Author
Ah Nevermind, I see the volume mounts are not named that way, I will add the prefix to those as well |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses: #469