Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Archetype::{from_arrow, to_arrow} and friends tag compliant #8644

Open
wants to merge 1 commit into
base: cmc/eager_partial_1_descriptor_methods
Choose a base branch
from

Conversation

teh-cmc
Copy link
Member

@teh-cmc teh-cmc commented Jan 10, 2025

These methods were still ComponentName-based, which just won't work as we start introducing archetypes with multiple instances of the same component.

Note that these methods are very seldom used (only for tests, IIRC), so I went for the path of least resistance and took a few shortcuts.
We can build something sturdier later on if need be (I highly doubt it... in fact I expect these methods don't have that much time left to live).

Copy link

github-actions bot commented Jan 10, 2025

Web viewer built successfully. If applicable, you should also test it:

  • I have tested the web viewer
Result Commit Link Manifest
1ecedd4 https://rerun.io/viewer/pr/8644 +nightly +main

Note: This comment is updated whenever you push a commit.

@teh-cmc teh-cmc marked this pull request as ready for review January 10, 2025 16:09
@teh-cmc teh-cmc added 🦀 Rust API Rust logging API do-not-merge Do not merge this PR codegen/idl exclude from changelog PRs with this won't show up in CHANGELOG.md labels Jan 10, 2025
@emilk emilk self-requested a review January 10, 2025 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
codegen/idl do-not-merge Do not merge this PR exclude from changelog PRs with this won't show up in CHANGELOG.md 🦀 Rust API Rust logging API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants