Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run build_tests on Windows #7065

Merged
merged 2 commits into from
Oct 5, 2024
Merged

Run build_tests on Windows #7065

merged 2 commits into from
Oct 5, 2024

Conversation

cknitt
Copy link
Member

@cknitt cknitt commented Oct 2, 2024

Gets most of build_tests running on Windows.

OUnit tests remain disabled on Windows, we can have a look at those later.

@cknitt cknitt force-pushed the windows branch 3 times, most recently from 063af70 to d11d40e Compare October 4, 2024 17:57
@cknitt cknitt force-pushed the windows branch 18 times, most recently from 258e12a to 61b9cc9 Compare October 5, 2024 12:59
@cknitt cknitt changed the title Run more tests on Windows Run build_tests on Windows Oct 5, 2024
@cknitt cknitt marked this pull request as ready for review October 5, 2024 13:01
@cknitt cknitt requested review from zth and cristianoc October 5, 2024 13:06
Copy link
Collaborator

@cristianoc cristianoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohhh it works

@cknitt
Copy link
Member Author

cknitt commented Oct 5, 2024

Ohhh it works

Finally... 😉

@cknitt cknitt merged commit 597e453 into rescript-lang:master Oct 5, 2024
20 checks passed
@cknitt cknitt deleted the windows branch October 5, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants