Some rewatch fixes #1033
Some rewatch fixes #1033
Conversation
server/src/incrementalCompilation.ts
Outdated
| @@ -376,7 +376,7 @@ function triggerIncrementalCompilationOfFile( | |||
| return; | |||
| } | |||
| const workspaceRootPath = projectRootPath | |||
| ? utils.findProjectRootOfFile(projectRootPath) | |||
| ? utils.findProjectRootOfFileInDir(projectRootPath) | |||
There was a problem hiding this comment.
findProjectRootOfFile is used intentionally here, because it'll look up the project root in a way that doesn't touch the FS unless necessary. It's an optimization, because this is called frequently and it was causing pretty severe slowness at times.
So, the correct fix here would be to make findProjectRootOfFile work instead.
There was a problem hiding this comment.
This should be fixed now
| either fromString fromName |> Option.map nameSpaceToName | ||
| let name = either fromString fromName |> Option.map nameSpaceToName in | ||
| match (namespaceEntry, name) with | ||
| | Some _, Some name -> Some ("@" ^ name) |
There was a problem hiding this comment.
I'm not sure I follow here, why is @ prepended?
There was a problem hiding this comment.
It's a way to create a namespace entry (entry module for a namespace in rewatch) - a feature we created and use @ Walnut.
There was a problem hiding this comment.
It allows you to have a namespace and create an entry module to the namespace, so not all modules are exposed. The @ is added to the normal namespace module, so it's impossible to import it syntaxwise, and it's opened in the entry module of the namespace, in that module it's possible to alias the modules that are exported from the package.
* pick up on namespace-entry * fix workspace lookup * fix crash when log file dissappears * fix * remove log * add changelog items
No description provided.