Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update: added independent param to NavigationContainer #64

Merged
merged 1 commit into from
Jun 13, 2024
Merged

update: added independent param to NavigationContainer #64

merged 1 commit into from
Jun 13, 2024

Conversation

witcher-shailesh
Copy link
Contributor

Adding binding for prop - independent to be able to accommodate nested independent NavigationContainer

@witcher-shailesh
Copy link
Contributor Author

@Freddy03h @MoOx

@Freddy03h
Copy link
Member

@witcher-shailesh I'm ok to merge it, but it seems it will be removed in the 7.xversion of react-navigation, replaced by a <NavigationIndependentTree> component.

Are you ok with that?

@witcher-shailesh
Copy link
Contributor Author

Thanks @Freddy03h, yes it should be fine for our current usecase. Later I can add bindings for the NavigationIndependentTree

@Freddy03h Freddy03h merged commit f75242d into rescript-react-native:main Jun 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@witcher-shailesh @Freddy03h