chore: fix label in base profile and remove tab index (sonarcloud adv…

…ice)
research-software-directory · Nov 30, 2023 · 3780ff7 · 3780ff7
1 parent ad7e75b
commit 3780ff7
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 7 deletions.
diff --git a/frontend/components/layout/ConfirmDeleteModal.tsx b/frontend/components/layout/ConfirmDeleteModal.tsx
@@ -67,7 +67,6 @@ export default function ConfirmDeleteModal({
         padding: '1rem 1.5rem',
       }}>
         <Button
-          tabIndex={1}
           onClick={onCancel}
           color="secondary"
           sx={{
@@ -77,7 +76,6 @@ export default function ConfirmDeleteModal({
             Cancel
         </Button>
         <Button
-          tabIndex={0}
           type="button"
           variant="contained"
           color="error"

diff --git a/frontend/components/user/settings/BasicProfile.tsx b/frontend/components/user/settings/BasicProfile.tsx
@@ -41,9 +41,8 @@ export default function BasicProfile({orcid}:BasicProfileProps) {
           <a href={`/profile/${orcid}/software`} className="flex gap-2 items-center" target='_blank'>
             Enabled <LaunchIcon sx={{width:'1rem'}}/>
           </a>
-          : <a href="/documentation/users/user-settings/#public-profile" target='_blank'>
-            Disabled <LaunchIcon sx={{width:'1rem'}}/>
-          </a>
+          :
+          <span>Disabled (<a href="/documentation/users/user-settings/#public-profile" target='_blank'>how to enable? <LaunchIcon sx={{width:'1rem'}}/></a>)</span>
         }
       </div>
     </>

diff --git a/frontend/components/user/settings/UserAgreementModal.tsx b/frontend/components/user/settings/UserAgreementModal.tsx
@@ -163,7 +163,6 @@ export default function UserAgrementModal() {
           padding: '1rem 1.5rem',
         }}>
           <Button
-            tabIndex={1}
             // on cancel go back to previous page
             onClick={()=>router.back()}
             color="secondary"
@@ -175,7 +174,6 @@ export default function UserAgrementModal() {
           </Button>
           <Button
             form="user-agreement-form"
-            tabIndex={0}
             disabled={!(agreeTerms && privacyStatement)}
             type="submit"
             variant="contained"