Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use EditorConfig #1328

Merged
merged 4 commits into from
Oct 28, 2024
Merged

Use EditorConfig #1328

merged 4 commits into from
Oct 28, 2024

Conversation

ewan-escience
Copy link
Collaborator

Use EditorConfig

Changes proposed in this pull request

  • Add a .editorconfig to some of the backend modules to ensure consistent basic formatting (as there is no good formatter for Java)
  • Add a GitHub workflow that checks if files are compliant with the EditorConfig settings
  • Add some info on EditorConfig to the respective README files

How to test

  • docker compose down --volumes && docker compose build --parallel && docker compose up --scale data-generation=0
  • Check out the new info in the README files

Related to #915

PR Checklist:

  • Increase version numbers in docker-compose.yml
  • Link to a GitHub issue
  • Update documentation
  • Tests

@ewan-escience ewan-escience self-assigned this Oct 24, 2024
Copy link

Copy link

Copy link

Comment on lines +9 to +10
pull_request:

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would favor running this check only when something is changed in the Java folders (see frontend_tests.yml for example)?

@ewan-escience ewan-escience merged commit 712468c into main Oct 28, 2024
9 checks passed
@ewan-escience ewan-escience deleted the 915-editorconfig branch November 12, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants