-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: software mentions counts on homepage #1329
Conversation
Works as expected for the test cases described above. I also tested manually adding a mention to software1 that was also found automatically. This isn't counted twice, which is correct. When also adding this same mention manually to software2 it is counted. This is also correct. However, if I use the same reference paper for both software 1 and software 2, the citations are only counted once. I don't think this is correct? I agree this is an artificial example though. A more realistic one is the following: AMBER has 10.1016/j.softx.2020.100549 as one of it's reference papers. This is cited 13 times. KernelTuner has 10.1016/j.future.2018.08.004 as one of it reference papers. This is cited 64 times. Because these are different pieces of software, the total citation count should be 13+64 = 77. However, the RSD only reports 75, because some citations are coming from the same source. For example this book chapter 10.1007/978-3-031-69577-3_7 cites both AMBER and KernelTuner. It should count as 2, but is now only counted as 1. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works well, I'll leave it up to @jmaassen to decide if the semantics should be changed.
c07ca2d
to
ddcdb75
Compare
@jmaassen I have adjusted RPC to count on unique combination of mention and software id's. Using this approach we count one paper multiple times if it references more than one RSD software entry. Can you test it again, please? |
…unt unique entries per software and mention id.
ddcdb75
to
576f7fa
Compare
Quality Gate passed for 'rsd-database'Issues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as expected. The overall count on the landing pages makes sense now.
Improve mention count on homepage
Closes #1326
Changes proposed in this pull request:
How to test:
docker compose build && docker compose up
Example software overview
PR Checklist:
docker-compose.yml