Add ability to reweight target basket #1022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add ability to reweight target basket
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
tbrent
changed the title
|
This PR is much smaller than I expected, haha. |
It was much larger before |
|
Holding off on reviewing/merging until we decide on immutable/mutable |
tbrent
force-pushed
the
change-target-basket
branch
from
36cb04d to
a8fac29
Compare
|
@akshatmittal ready for review |
akshatmittal
requested changes
Dec 8, 2023
|
How would that work? Has to be set in the `init()` not constructor.
…On Fri, Dec 8, 2023, 11:42 AM Akshat Mittal ***@***.***> wrote:
***@***.**** requested changes on this pull request.
------------------------------
In contracts/p1/BasketHandler.sol
<#1022 (comment)>
:
> @@ -79,6 +79,12 @@ contract BasketHandlerP1 is ComponentP1, IBasketHandler {
// Effectively local variable of `requireConstantConfigTargets()`
EnumerableMap.Bytes32ToUintMap private _targetAmts; // targetName -> {target/BU}
+ // ===
+ // Added in 3.2.0
+
+ // Whether the total weights of the target basket can be changed
+ bool public reweightable; // immutable after init
Maybe actually make this immutable?
—
Reply to this email directly, view it on GitHub
<#1022 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADGRGM6GCIW6O4FA3QX2IU3YIM7OXAVCNFSM6AAAAABAG6VUY6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTONZSG44TEMZQG4>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
akshatmittal
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This turned out to be simpler than I thought because you don't actually need to forbid redemptions from previous basket nonces of different worths. I want the reviewer to think through this to confirm, though.
Only annoying part was we hit contract size limit and had to move to a slightly less readable way of applying the
governancemodifier.Regarding tests:
freshBasketHandlerwas no longer required now that governance can make an RToken revaluable.