Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: integrate with Euler V2 vaults #231

Merged
merged 42 commits into from
Nov 28, 2024
Merged

feat: integrate with Euler V2 vaults #231

merged 42 commits into from
Nov 28, 2024

Conversation

xenide
Copy link
Contributor

@xenide xenide commented Nov 17, 2024

Motivation

We need to integrate our AMM with Euler instead of AAVE, since we will be supplying our assets there.

Outstanding items:

  • handle pause / frozen cases for euler
    • not handling, in line with how we integrated with aave previously
  • integrate additional rewards
  • track total shares and only allow the admin to set another vault when the totalShares is 0

Solution

@xenide xenide marked this pull request as ready for review November 20, 2024 02:11
@xenide xenide requested a review from OliverNChalk November 20, 2024 02:15
test/integration/Euler.t.sol Show resolved Hide resolved
src/asset-management/EulerV2Manager.sol Show resolved Hide resolved
src/asset-management/EulerV2Manager.sol Outdated Show resolved Hide resolved
src/asset-management/EulerV2Manager.sol Outdated Show resolved Hide resolved
src/asset-management/EulerV2Manager.sol Outdated Show resolved Hide resolved
src/asset-management/EulerV2Manager.sol Show resolved Hide resolved
@xenide xenide force-pushed the feat/supply-euler-vaults branch from cf316f4 to 27a6944 Compare November 26, 2024 06:41
Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.76%. Comparing base (69c7c52) to head (c1a6373).
Report is 3 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #231      +/-   ##
==========================================
- Coverage   88.04%   85.76%   -2.29%     
==========================================
  Files          12       24      +12     
  Lines         619      899     +280     
==========================================
+ Hits          545      771     +226     
- Misses         74      128      +54     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@OliverNChalk OliverNChalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small comments so far. Really good looking code, hard to find things to complain about haha

src/asset-management/EulerV2Manager.sol Show resolved Hide resolved
src/asset-management/EulerV2Manager.sol Show resolved Hide resolved
@xenide xenide merged commit e51e8e5 into dev Nov 28, 2024
7 of 11 checks passed
@xenide xenide deleted the feat/supply-euler-vaults branch November 28, 2024 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants