feat: individual thresholds and reverse dutch auction #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this ready to review, CI seems to be failing? |
OliverNChalk
reviewed
Aug 9, 2024
OliverNChalk
approved these changes
Aug 9, 2024
Comment on lines
+138
to
+139
| (address[] memory lRoute,, uint256 lPrevPrice, uint256 lRewardThreshold) = | ||
| _getRouteDecimalDifferencePrice(lToken0, lToken1); |
There was a problem hiding this comment.
Suggested change
| (address[] memory lRoute,, uint256 lPrevPrice, uint256 lRewardThreshold) = | |
| _getRouteDecimalDifferencePrice(lToken0, lToken1); | |
| (address[] memory lRoute, , uint256 lPrevPrice, uint256 lRewardThreshold) = | |
| _getRouteDecimalDifferencePrice(lToken0, lToken1); |
make it more obvious you're dropping a variable
| @@ -329,7 +342,7 @@ contract ReservoirPriceOracle is IPriceOracle, Owned(msg.sender), ReentrancyGuar | |||
| if (aAmount > Constants.MAX_AMOUNT_IN) revert OracleErrors.AmountInTooLarge(); | |||
|
|
|||
| (address lToken0, address lToken1) = Utils.sortTokens(aBase, aQuote); | |||
| (address[] memory lRoute, int256 lDecimalDiff, uint256 lPrice) = | |||
| (address[] memory lRoute, int256 lDecimalDiff, uint256 lPrice,) = | |||
There was a problem hiding this comment.
suggest maybe always putting a space after , when dropping a variable?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.