Add tests

resetius · Nov 25, 2023 · cefead1 · cefead1
1 parent 3650388
commit cefead1
Show file tree

Hide file tree

Showing 3 changed files with 51 additions and 1 deletion.
diff --git a/src/messages.h b/src/messages.h
@@ -54,8 +54,11 @@ static_assert(sizeof(TRequestVoteRequest) == sizeof(TMessageEx)+24);
 struct TRequestVoteResponse: public TMessageEx {
     static constexpr EMessageType MessageType = EMessageType::REQUEST_VOTE_RESPONSE;
     uint32_t VoteGranted;
+    uint32_t Padding = 0;
 };
 
+static_assert(sizeof(TRequestVoteResponse) == sizeof(TMessageEx)+8);
+
 struct TAppendEntriesRequest: public TMessageEx {
     static constexpr EMessageType MessageType = EMessageType::APPEND_ENTRIES_REQUEST;
     uint64_t PrevLogIndex;

diff --git a/src/raft.h b/src/raft.h
@@ -114,9 +114,10 @@ class TRaft {
         return Id;
     }
 
+    std::unique_ptr<TResult> Candidate(ITimeSource::Time now, TMessageHolder<TMessage> message);
+
 private:
     std::unique_ptr<TResult> Follower(ITimeSource::Time now, TMessageHolder<TMessage> message);
-    std::unique_ptr<TResult> Candidate(ITimeSource::Time now, TMessageHolder<TMessage> message);
     std::unique_ptr<TResult> Leader(ITimeSource::Time now, TMessageHolder<TMessage> message);
 
     std::unique_ptr<TResult> OnRequestVote(TMessageHolder<TRequestVoteRequest> message);

diff --git a/test/test_raft.cpp b/test/test_raft.cpp
@@ -442,6 +442,50 @@ void test_candidate_initiate_election(void**) {
     assert_message_equal(messages[1], r);
 }
 
+void test_candidate_vote_request_small_term(void**) {
+    auto ts = std::make_shared<TFakeTimeSource>();
+    auto raft = MakeRaft({}, 3, ts);
+    auto req = NewHoldedMessage<TRequestVoteRequest>();
+    req->Src = 2;
+    req->Dst = 1;
+    req->Term = 0;
+    req->CandidateId = 2;
+    req->LastLogTerm = 1;
+    req->LastLogIndex = 1;
+    auto result = raft->Candidate(ts->Now(), std::move(req));
+    TRequestVoteResponse r;
+    r.Type = static_cast<uint32_t>(EMessageType::REQUEST_VOTE_RESPONSE);
+    r.Len = sizeof(r);
+    r.Src = 1;
+    r.Dst = 2;
+    r.Term = raft->GetState()->CurrentTerm;
+    r.VoteGranted = false;
+    assert_message_equal(result->Message, r);
+    assert_int_equal(raft->GetState()->CurrentTerm, 1);
+}
+
+void test_candidate_vote_request_ok_term(void**) {
+    auto ts = std::make_shared<TFakeTimeSource>();
+    auto raft = MakeRaft({}, 3, ts);
+    auto req = NewHoldedMessage<TRequestVoteRequest>();
+    req->Src = 2;
+    req->Dst = 1;
+    req->Term = 1;
+    req->CandidateId = 2;
+    req->LastLogTerm = 1;
+    req->LastLogIndex = 1;
+    auto result = raft->Candidate(ts->Now(), std::move(req));
+    TRequestVoteResponse r;
+    r.Type = static_cast<uint32_t>(EMessageType::REQUEST_VOTE_RESPONSE);
+    r.Len = sizeof(r);
+    r.Src = 1;
+    r.Dst = 2;
+    r.Term = raft->GetState()->CurrentTerm;
+    r.VoteGranted = true;
+    assert_message_equal(result->Message, r);
+    assert_int_equal(raft->GetState()->CurrentTerm, 1);
+}
+
 int main() {
     const struct CMUnitTest tests[] = {
         cmocka_unit_test(test_empty),
@@ -462,6 +506,8 @@ int main() {
         cmocka_unit_test(test_follower_append_entries_7f),
         cmocka_unit_test(test_follower_append_entries_empty_to_empty_log),
         cmocka_unit_test(test_candidate_initiate_election),
+        cmocka_unit_test(test_candidate_vote_request_small_term),
+        cmocka_unit_test(test_candidate_vote_request_ok_term),
     };
     return cmocka_run_group_tests(tests, NULL, NULL);
 }