feat: support monorepos [PLAT-8693] #1299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prescottprue
requested review from
hershmire and
mathieudi
and removed request for
a team
|
🎉 This PR is included in version 3.2.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
hershmire
reviewed
Mar 6, 2025
| @@ -8,6 +8,9 @@ inputs: | |||
| output-file: | |||
| required: false | |||
| description: 'Path for output json file' | |||
| is-monorepo: | |||
There was a problem hiding this comment.
Curious if this is necessary. What about looking at the package.json file to see if there's a workspace field.
|
|
||
| // If package is a monorepo report on each subpackage | ||
| if (isMonorepoInput === 'true') { | ||
| const packageFolders = fs.readdirSync(`${process.cwd()}/packages`); |
There was a problem hiding this comment.
I think this should reference the workspace value coming from package.json instead of assuming that all our monorepos are under packages/.
| percentsByName[packageFolder] = pkgDepStats.percents; | ||
| const outputFileConfig = core.getInput('output-file'); | ||
| if (outputFileConfig) { | ||
| fs.writeFileSync( |
There was a problem hiding this comment.
Should this use the promise version vs the synchronous one?
| > = {}; | ||
| const countsByName: Record<string, GlobalStatsOutput['counts']> = {}; | ||
| const percentsByName: Record<string, GlobalStatsOutput['percents']> = {}; | ||
| await Promise.allSettled( |
There was a problem hiding this comment.
Do you care to log any potential errors?
prescottprue
added a commit
that referenced
this pull request
Mar 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ TICKET-000
Upstream PRs
Downstream PRs
Changes
Notes for Reviewers
Recordings/Screenshots