Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing argument not being passed by reference. Strongly enhances field computation time! #92

Merged
merged 8 commits into from
May 3, 2024

Conversation

jgalan
Copy link
Member

@jgalan jgalan commented May 3, 2024

jgalan Medium: 135 Powered by Pull Request Badge

I just created as a copy of PR #90 but removing all the fit related implementations.

HOT Fix on method with argument not being passed by reference! Thanks @LouisHelary

@jgalan jgalan requested a review from LouisHelary May 3, 2024 12:46
@jgalan jgalan self-assigned this May 3, 2024
@jgalan jgalan changed the title Updates Fixing argument not being passed by reference. Strongly enhances field computation time! Thanks @LouisHelary May 3, 2024
@jgalan jgalan marked this pull request as ready for review May 3, 2024 13:37
@jgalan jgalan changed the title Fixing argument not being passed by reference. Strongly enhances field computation time! Thanks @LouisHelary Fixing argument not being passed by reference. Strongly enhances field computation time! May 3, 2024
Copy link
Contributor

@LouisHelary LouisHelary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the implementation!

@LouisHelary LouisHelary merged commit 3802d10 into master May 3, 2024
63 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants