Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the new awakeable identifier format #105

Merged
merged 3 commits into from
Aug 15, 2023
Merged

Use the new awakeable identifier format #105

merged 3 commits into from
Aug 15, 2023

Conversation

slinkydeveloper
Copy link
Contributor

Fix #103

@slinkydeveloper
Squashed 'sdk-core-impl/src/main/service-protocol/' changes from 8508…
e593ac6 
…1ed..fcfe65f

fcfe65f Add CompleteAwakeableEntryMessage.failure (#44)
f7f95a3 Define how to ser/de the awakeable identifier (#42)

git-subtree-dir: sdk-core-impl/src/main/service-protocol
git-subtree-split: fcfe65f7abf7464f537e274937eef77acad61ec7
@slinkydeveloper
Merge commit 'e593ac64467b3aea4022a9477dfd2a0e1a781592' into issues/103
6e8c1af
@github-actions
Copy link
Contributor

github-actions bot commented Aug 15, 2023 •
edited
Loading

Unit Test Results

144 tests  ±0   144 ✔️ ±0   9s ⏱️ -1s
  14 suites ±0       0 💤 ±0 
  14 files   ±0       0 ❌ ±0 

Results for commit 0ce7429. ± Comparison against base commit d9ebad4.

♻️ This comment has been updated with latest results.

@slinkydeveloper slinkydeveloper mentioned this pull request Aug 15, 2023
Merged
@slinkydeveloper
Copy link
Contributor Author

Tested locally with restatedev/e2e#185 and it works

tillrohrmann
tillrohrmann approved these changes Aug 15, 2023
View reviewed changes
Copy link
Contributor

@tillrohrmann tillrohrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. +1 for merging.

sdk-blocking/src/main/java/dev/restate/sdk/blocking/RestateContext.java Show resolved Hide resolved
@slinkydeveloper slinkydeveloper merged commit ab4b604 into main Aug 15, 2023
3 checks passed
@slinkydeveloper slinkydeveloper deleted the issues/103 branch August 15, 2023 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tillrohrmann tillrohrmann tillrohrmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update the awakeable identifier
2 participants
@slinkydeveloper @tillrohrmann