Closed
Conversation
Author
|
I'd say the main problems is that the italian This would probably need to implement that parsing and obtain KV with keys like "Registrar.Organization" or similar. (in the UI people is more interested in the organization name, not the technical name) |
Owner
|
Thanks for picking this up! Heads up: #8 rewrote the parser for exactly this case (bare section headers + section-prefixed aliases) |
Merged
Author
|
I guess this test (which now passes) is mostly superseded by your |
Owner
|
Yeah, closing since this is irrelevant now since stronger coverage is already on main |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work in progress. For now I improved the test case (which currently fails).
BTW: currently the program UI shows the registrar (i.e. the "store" where the domain was bought) which is fine, but it would make even more sense to show the registrant (i.e. the person that bought the domain).