Skip to content

Improve parsing for italian whois#6

Closed
lapo-luchini wants to merge 2 commits intoretlehs:mainfrom
lapo-luchini:italy
Closed

Improve parsing for italian whois#6
lapo-luchini wants to merge 2 commits intoretlehs:mainfrom
lapo-luchini:italy

Conversation

@lapo-luchini
Copy link
Copy Markdown

Work in progress. For now I improved the test case (which currently fails).

BTW: currently the program UI shows the registrar (i.e. the "store" where the domain was bought) which is fine, but it would make even more sense to show the registrant (i.e. the person that bought the domain).

@lapo-luchini lapo-luchini marked this pull request as draft April 11, 2026 17:43
@lapo-luchini
Copy link
Copy Markdown
Author

I'd say the main problems is that the italian whois uses "sections" and not a raw KV store.

Registrar
  Organization:     Aruba s.p.a.
  Name:             ARUBA-REG
  Web:              http://www.aruba.it
  DNSSEC:           yes

This would probably need to implement that parsing and obtain KV with keys like "Registrar.Organization" or similar. (in the UI people is more interested in the organization name, not the technical name)

@retlehs
Copy link
Copy Markdown
Owner

retlehs commented Apr 11, 2026

Thanks for picking this up! Heads up: #8 rewrote the parser for exactly this case (bare section headers + section-prefixed aliases)

@retlehs retlehs mentioned this pull request Apr 11, 2026
@lapo-luchini
Copy link
Copy Markdown
Author

I guess this test (which now passes) is mostly superseded by your TestParse_NicITSectionedFormat then. :)
Should I close?

@lapo-luchini lapo-luchini marked this pull request as ready for review April 12, 2026 08:40
@retlehs
Copy link
Copy Markdown
Owner

retlehs commented Apr 12, 2026

Yeah, closing since this is irrelevant now since stronger coverage is already on main

@retlehs retlehs closed this Apr 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants