🐛 Clean up pending transfer on upload interruption#26
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds an explicit “force delete” API call and wires SIGINT/SIGTERM handling into transfer create so that interrupted uploads don’t leave orphaned pending transfers on the server.
Changes:
- Add
Client.ForceDeleteTransfer()(DELETE/share/{id}/force) for permanently deleting pending transfers. - In
transfer create, install a SIGINT/SIGTERM handler after share creation; on interruption cancel ongoing upload work and force-delete the pending transfer. - Prompt for a passphrase earlier (when determinable) to avoid creating a server-side pending share during interactive passphrase entry.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| internal/api/transfer.go | Adds ForceDeleteTransfer API method used for cleanup of pending transfers. |
| cmd/transfer.go | Adds signal handling + cleanup logic during transfer creation/upload and adjusts passphrase prompting order. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
On SIGINT/SIGTERM, during a transfer, perform a deleting of the transfer in "pending" state.
HanXHX
force-pushed
the
manage_aborted_transfer
branch
from
75cce3e to
05139c4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On SIGINT/SIGTERM, during a transfer, perform a deleting of the transfer in "pending" state.