bitcoind: Use Miniscript descriptors for the watchonly wallet #419
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By ignoring more entries that are obviously not the one we are looking for
- Don't generate a set of addresses to be imported, import the ranged Miniscript descriptors directly. - Tell listsinceblock to list change, too (custom bitcoind patch). This is necessary because deposit addresses aren't part of bitcoind's address book anymore and we would otherwise fail to detect some deposits. - Use the 'wallet_desc' field in listsinceblock entries to track coins, instead of the former labels imported along with the addresses. This also cleans up the descriptor import routines.
darosior
force-pushed
the
miniscript_new
branch
8 times, most recently
from
316d046 to
072f428
Compare
|
All upstream PRs were merged in order to support this. We'll be able to merge this PR once 24.0 is released. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on our #418.
This a PoC to demonstrate coin tracking by importing ranged Miniscript descriptors to
bitcoindinstead of addresses.This uses:
I've tweaked the bitcoind used in CI to demonstrate all functional tests pass.