REVAI-3854: SuperApi features #59

kirillatrev · 2023-12-13T22:35:04Z

REVAI-3854: Initial draft

src/main/java/ai/rev/speechtotext/ApiClient.java

src/main/java/ai/rev/speechtotext/ApiInterface.java

src/main/java/ai/rev/speechtotext/models/NlpModel.java

src/main/java/ai/rev/speechtotext/models/asynchronous/RevAiJob.java

src/main/java/ai/rev/speechtotext/models/asynchronous/RevAiJobOptions.java

src/main/java/ai/rev/speechtotext/models/asynchronous/Summarization.java

src/main/java/ai/rev/speechtotext/models/asynchronous/SummarizationFormattingOptions.java

src/main/java/ai/rev/speechtotext/models/asynchronous/SummarizationJobStatus.java

src/main/java/ai/rev/speechtotext/models/asynchronous/SummarizationOptions.java

src/main/java/ai/rev/speechtotext/models/asynchronous/Summary.java

src/main/java/ai/rev/speechtotext/models/asynchronous/TranslationJobStatus.java

src/main/java/ai/rev/speechtotext/models/asynchronous/Translation.java

src/main/java/ai/rev/speechtotext/models/asynchronous/TranslationLanguage.java

dmtrrk · 2023-12-15T17:14:47Z

src/main/java/ai/rev/speechtotext/models/NlpModel.java

+
+import com.google.gson.annotations.SerializedName;
+
+/** Model type. */


This looks like can be more verbose

dmtrrk · 2023-12-15T17:20:04Z

src/main/java/ai/rev/speechtotext/models/NlpModel.java

+
+    @Override
+    public String toString() {
+        return "{" + "model='" + model + '\'' + '}';


what is the purpose of having it in this format? why can't consumer of this type format it as needed?

I don't know what the intention was, but I follow the same pattern. JobOptions class at the top level calls .toString() on every member and expects this output.

yeah, really. at last for some nested models we have this formatting.
@amikofalvy by any chance do you know what was the purpose?

dmtrrk · 2023-12-15T17:23:48Z

src/main/java/ai/rev/speechtotext/models/asynchronous/RevAiJobOptions.java

+    this.summarizationOptions = summarizationOptions;
+  }
+
+  public TranslationOptions getTranslationOptions() {


I think here should be a comment

dmtrrk · 2023-12-15T17:32:12Z

src/main/java/ai/rev/speechtotext/models/asynchronous/Summarization.java

+  private String prompt;
+
+  /** Standard or Premium AI backend. * */
+  @SerializedName("model")


not sure we can have any other model type, but we can say something like summarization model and then @see NlpModel. then we can extend the NlpModel as we need without other changes

dmtrrk · 2023-12-15T17:34:18Z

src/main/java/ai/rev/speechtotext/models/asynchronous/SummarizationFormattingOptions.java

+
+import com.google.gson.annotations.SerializedName;
+
+/** Summarization formatting options. * */


is there a purpose for * */? I see it everywhere in this PR

This is how autoformatted puts it

I did not find anything relevant in Google. Also, I don't see it like this in other files. Even in some of your files there is a single star only

Okay. Thanks auto formatter! :-)
I'll spend some more time on this.

kirillatrev requested a review from a team as a code owner December 13, 2023 22:35

kirillatrev marked this pull request as draft December 13, 2023 22:42