Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REVAI-3854: Usage examples #62

Merged
merged 3 commits into from
Dec 26, 2023
Merged

Conversation

kirillatrev
Copy link
Collaborator

REVAI-3854: Usage examples

README.md Outdated
revAiJobOptions.setSourceConfig(urlLinkToFile, null);
revAiJobOptions.setLanguage("en");
revAiJobOptions.setSummarizationOptions(new SummarizationOptions().setModel(NlpModel.STANDARD));

Copy link
Collaborator

@dmtrrk dmtrrk Dec 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

redundant
upd. the line 81 is the empty line. it does not look like we need it


// Waits 5 seconds between each status check to see if job is complete
boolean isJobComplete = false;
while (!isJobComplete) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

once this is a summarization example, not sure we need this block as it makes the example more complicated.
can we do a summarization polling only?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexsku are you okay with that?
You were requesting polling those jobs in order in python sdk...

Copy link
Collaborator

@dmtrrk dmtrrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is a question regarding polling, but it looks like this approach is ok for SDKs in other languages

@kirillatrev kirillatrev merged commit a8ca699 into develop Dec 26, 2023
6 checks passed
@kirillatrev kirillatrev deleted the feature/REVAI-3854-examples branch December 26, 2023 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants