-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
REVAI-3854: Usage examples #62
Conversation
README.md
Outdated
revAiJobOptions.setSourceConfig(urlLinkToFile, null); | ||
revAiJobOptions.setLanguage("en"); | ||
revAiJobOptions.setSummarizationOptions(new SummarizationOptions().setModel(NlpModel.STANDARD)); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
redundant
upd. the line 81 is the empty line. it does not look like we need it
|
||
// Waits 5 seconds between each status check to see if job is complete | ||
boolean isJobComplete = false; | ||
while (!isJobComplete) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
once this is a summarization example, not sure we need this block as it makes the example more complicated.
can we do a summarization polling only?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alexsku are you okay with that?
You were requesting polling those jobs in order in python sdk...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there is a question regarding polling, but it looks like this approach is ok for SDKs in other languages
REVAI-3854: Usage examples