Add next button wait and timeout #489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbollen23
approved these changes
Nov 5, 2024
| @@ -1,5 +1,5 @@ | |||
| { | |||
| "$schema": "https://raw.githubusercontent.com/revisit-studies/study/v1.0.5/src/parser/StudyConfigSchema.json", | |||
| "$schema": "https://raw.githubusercontent.com/revisit-studies/study/time-to-next/src/parser/StudyConfigSchema.json", | |||
There was a problem hiding this comment.
Confused what the change is for? Just for testing the schema validation?
There was a problem hiding this comment.
This lets the tests pass here, not just locally. It uses the updated schema
| {`${key}: `} | ||
| </Text> | ||
| <Text span> | ||
| {`${storedAnswer}`} |
There was a problem hiding this comment.
Suggested change
| {`${storedAnswer}`} | |
| {storedAnswer} |
Can it just be this? Note sure if there is a "string/number" issue that you're trying to avoid here.
There was a problem hiding this comment.
Yes it's a type issue:
Type '{ id: string; value: unknown; }' is not assignable to type 'ReactNode'.
Co-authored-by: bbollen23 <briancbollen@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does this PR close any open issues?
Closes #449
Give a longer description of what this PR addresses and why it's needed
This pull request introduces a new feature to control the timing of the "Next" button in the response block, along with some schema updates and UI enhancements.
Adds a timer and 2 config options that either require a certain to have passed before the next button becomes available or disables the next button after a certain amount of time.
I had to modify some helpers slightly so that the participant answers would not be recorded on an incorrect answer. We still save a StoredAnswer (so we can replay provenance, etc.), but don't save any answers from the answer validator.
Provide pictures/videos of the behavior before and after these changes (optional)
Are there any additional TODOs before this PR is ready to go?
TODOs: