Merged
Conversation
There was a problem hiding this comment.
2 issues found across 2 files
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="scripts/generate-spec-md.ts">
<violation number="1" location="scripts/generate-spec-md.ts:15">
P2: Silently returning an empty string for unknown features will hide missing/typoed feature names and generate incomplete SPEC.md without any error. Failing fast (or logging) makes regressions detectable.</violation>
</file>
<file name="SPEC.md">
<violation number="1" location="SPEC.md:232">
P2: Document the minVersion for `array_wildcard_property` in the Version Detection table; it’s now a supported v1.1 feature but is omitted from the table, so readers won’t see how the parser reports it.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary by cubic
Adds wildcard array property access ([*]) and expands the formula spec with new path and context features. Updates the spec generator to auto-render features with consistent formatting and dependency notes.
New Features
Refactors
Written for commit e3479ff. Summary will update on new commits. Review in cubic