Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update minio health check #80

Merged
merged 1 commit into from
Mar 28, 2024
Merged

fix: update minio health check #80

merged 1 commit into from
Mar 28, 2024

Conversation

r-o-b-o-t-o
Copy link
Contributor

  • I understand and have followed the contribution guide
  • I have tested my changes locally and they are working as intended

This PR fixes the createbuckets service.
curl is not available in the minio/mc image anymore, it can be replaced with the mc ready command.

Probably fixes #76

@killforby
Copy link

mc: Couldn't construct anonymous client for minio. No valid configuration found for 'minio' host alias.

Waiting minio...

@killforby
Copy link

it's ok , sorry

insertish
insertish approved these changes Mar 28, 2024
View reviewed changes
Copy link
Member

@insertish insertish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for the fix

@insertish insertish merged commit cabb853 into revoltchat:master Mar 28, 2024
2 checks passed
@r-o-b-o-t-o r-o-b-o-t-o deleted the fix/update-minio-health-check branch March 28, 2024 14:21
@insertish insertish mentioned this pull request Mar 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@insertish insertish insertish approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Pull Request Overview
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: s3Error
3 participants
@r-o-b-o-t-o @killforby @insertish