-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade dependencies #492
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the new HexaPDF::Composer#styles from HexaPDF 0.45.0 to simplify font/styles configuration
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #492 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 48 48
Lines 670 665 -5
Branches 53 53
=========================================
- Hits 670 665 -5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Now that we upgraded Ruby we can remove our ignore for end-of-life Ruby 3.1
04f1e9c
to
377d18c
Compare
New in Ruby 3.4.0
benoitlx
approved these changes
Mar 31, 2025
D0gmaDev
approved these changes
Mar 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The HexaPDF upgrade has been "visually tested", by generating a PDF with the 0.40.0 and the 1.2.0 and comparing the two ^^
Thanks to the turbo-rails upgrade we can remove the workaround because we don't use ActionCable.
I also needed to upgrade to Ruby 3.4 to fix standard gems confusion when running the CI (bundler/rubygems would confuse the bundled error_highlight gem when we have a specific version in our Gemfile). This in turn meant that I could remove our Brakeman configuration ignoring the end-of-life or Ruby 3.1, and add checksums to dependencies in Gemfile.lock (ensuring that if a gem is compromised on the RubyGems.org server we won't install it).
Code coverage for ERB files has not yet been enabled, as it would reduce the total code coverage. We will add it in a future PR.