Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade dependencies #492

Merged
merged 15 commits into from
Mar 31, 2025
Merged

chore: upgrade dependencies #492

merged 15 commits into from
Mar 31, 2025

Conversation

nymous
Copy link
Member

@nymous nymous commented Mar 30, 2025

The HexaPDF upgrade has been "visually tested", by generating a PDF with the 0.40.0 and the 1.2.0 and comparing the two ^^

Thanks to the turbo-rails upgrade we can remove the workaround because we don't use ActionCable.

I also needed to upgrade to Ruby 3.4 to fix standard gems confusion when running the CI (bundler/rubygems would confuse the bundled error_highlight gem when we have a specific version in our Gemfile). This in turn meant that I could remove our Brakeman configuration ignoring the end-of-life or Ruby 3.1, and add checksums to dependencies in Gemfile.lock (ensuring that if a gem is compromised on the RubyGems.org server we won't install it).

Code coverage for ERB files has not yet been enabled, as it would reduce the total code coverage. We will add it in a future PR.

@nymous nymous changed the title chore: dependencies chore: upgrade dependencies Mar 30, 2025
Copy link

codecov bot commented Mar 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (e2c71ad) to head (5bdbfde).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #492   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           48        48           
  Lines          670       665    -5     
  Branches        53        53           
=========================================
- Hits           670       665    -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

nymous added 2 commits March 30, 2025 21:02
Now that we upgraded Ruby we can remove our ignore for end-of-life Ruby
3.1
@nymous nymous force-pushed the upgrade-dependencies branch from 04f1e9c to 377d18c Compare March 30, 2025 19:02
@DioFun DioFun merged commit 7b2af8f into master Mar 31, 2025
7 checks passed
@DioFun DioFun deleted the upgrade-dependencies branch March 31, 2025 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants