Interrogative Types for English #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rbs for interrogatives in Questions. Added question test, which fails on Dutch unfortunately.
|
This fix for |
…ld be changed at the level of looking up the correct inflection with the buildPresentVerb method.
…r interrogatives and made tests for Dutch interrogatives
…ode that was deprecated
… verb for HOW_ADJECTIVE. Updated Dutch test with last two types of interrogatives, though needs a fix for the auxiliary verb realization.
|
Closed this pull request, because the interrogative types need some more attention before updating this in the public domain. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1 Fix for making proper verb inflection for interrogative types in English. Dutch unfortunately is a special case, where for generating a question, the verb for
PERSON.SECONDbecomes like the inflection forPERSON.FIRST.