Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

init_dir: use masterkey arg #831

Merged
merged 1 commit into from
Mar 13, 2024
Merged

init_dir: use masterkey arg #831

merged 1 commit into from
Mar 13, 2024

Conversation

pmazzini
Copy link
Contributor

@pmazzini pmazzini commented Mar 9, 2024

Fixes #824

@rfjakob
Copy link
Owner

rfjakob commented Mar 12, 2024

Code change is good, but needs a test. Can you add TestInitMasterkey similar to https://github.com/rfjakob/gocryptfs/blob/master/tests/cli/cli_test.go#L77 ?

rfjakob
rfjakob requested changes Mar 12, 2024
View reviewed changes
Copy link
Owner

@rfjakob rfjakob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code change is good, test is needed

pmazzini
pmazzini commented Mar 13, 2024
View reviewed changes
cli_args.go Show resolved Hide resolved
@rfjakob rfjakob merged commit 8ced867 into rfjakob:master Mar 13, 2024
7 checks passed
@rfjakob
Copy link
Owner

rfjakob commented Mar 13, 2024

Merged, thanks!

@pmazzini pmazzini deleted the pablo branch March 13, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rfjakob rfjakob rfjakob requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

directory init and masterkey arg
2 participants
@pmazzini @rfjakob