[fix] fix issue on vignette (issue #100) #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks for the fix (and sorry for the late reply -> holidays). |
jorainer
requested changes
Jul 31, 2023
There was a problem hiding this comment.
Thanks for the fix - only, I would prefer if you keep the name of the function scale_int because norm_int might be misleading. In fact we're scaling the intensities and not really normalizing them. I had already some discussions at a conference where users/workshop attendees were confused by this norm_int function.
|
I understand your concern, and I've made the necessary changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update scale_int to norm_int and add ... to function declaration