containElements returns TRUE for invalid elements #66
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #63.
containsElements
now returnsNA
forNA
, andFALSE
for invalid elements (like"Z"
).I am not sure about the return value for invalid elements. IMHO
NA
would be fine (in that case this PR is superfluous).If this PR is needed, we could argue about the use of
suppressWarnings
insidecontainsElements
.containsElements("H2O", "Z")
will returnFALSE
and produce a warning about "Z". (If we ignore this PR the result would beNA
anyway).