-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add linear model-based normalization functions #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add functions to perform linear model-based normalization, such as adjustment for an injection index dependent signal drift (issue #75).
philouail
reviewed
Dec 18, 2023
philouail
reviewed
Dec 18, 2023
philouail
reviewed
Dec 18, 2023
philouail
approved these changes
Dec 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good to me, I put a few comments. Very excited to try it out ! The code is also super clear in my opinion.
philouail
reviewed
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds functions that allow to perform a linear-model based normalization, which includes:
The functions perform row-wise adjustments, thus, a linear model if fitted for each "feature" separately, and the data will be adjusted (per feature) for this. Also, estimation of the bias can be performed on a subset of samples (e.g. QC samples) and applied in a second step to the full data set.
These functions are core/basic functions, more user convenient functions that base on these might be implemented elsewhere.