Phili

[philouail]

Here is the PR related to the issue #77.

These basic functions return single values and vectors (numeric for all expect for rowBlank which is logical).

This is a first draft, input is welcome, specifically on:

• naming of functions: for example should this really be called filteringFunctions ? as they don't really filter but more compute measurement of precision and detection / quality measurement of our data. I think a name reflecting that would be more accurate. qualityFunctions ?
• rowBlank threshold

Also, @jorainer I took your description and code for the rsd and rowRsd, it therefore needs to be removed from CompMetaboTools if you are fine with that.

I am currently writing the vignette but wanted to check if that was what you had in mind for now.
Also next I will implement more user friendly function that actually filter the data.

[jorainer]

Thanks for the great contribution @philouail ! I have some minor change requests.

[philouail]

Thanks for the comments I fixed them, do you have an opinion on the naming thing I was talking about ? replace filteringFunctions with some kind of name that include quality instead ? as these functions don't filter.

I added a section to the vignettes to describe general use of these functions.

[jorainer]

Great contribution @philouail ! Also very clear description of the functionality in the vignette!

Also, I agree that "filtering" might not be the right term here - I would maybe do some re-formulations (talking about quality assessment and less of filtering) and also rename the R file accordingly.

[philouail]

The naming system is now fixed !

@michaelwitting what do you think ? any ideas for improvement ?

[michaelwitting]

Looks good to me.