-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: support ProForma delta mass notation for individual modifications #17
base: main
Are you sure you want to change the base?
Conversation
Thanks @sgibb for this. I do agree that it would be nice addition, and a good reason to revive (and possibly extend) the unimod package. What would be the best way to proceed?
|
Re PSI-MOD, the rols package can be used query the ontology:
but if we want to go that way, we should store the modification tables in the package. |
The unimod was and is a great example of over-engineering. We (I) lost the focus on the KISS principle and never finished this very useful package. To be honest I am not able to motivate myself to start working on finishing unimod/a modification package. |
+1 for KISS. I'll discuss with @guideflandre to what extend supporting more formal modifications would be useful for his work and follow up if deemed worth investing the time. Let's start simple. |
This PR is WIP and should solve the issues #14 and #15 . Both ask for individual modifications on a specific amino acid in the peptide sequence. I add a very basic HUPO-PSI ProForma parser that only supports the delta mass notation.
Delta mass is given as + or - mass in square brackets behind the amino acid of interest, e.g. "P[+10]QR", or "P[-1.01]QR".
Problems:
TODOs:
"seq"
column in the returneddata.frame
.If we decide to support this notation we may discuss to support the ProForma global modification notation "SEQUENCE" as well (a modification in
<
,>
is attached in front of the sequence) (and may remove the"modification"
argument?).