docs/examples: match ior to text; use the same unit for A and µ; small typos #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IOR in the text and code didn't match
roflmaostc
reviewed
Mar 20, 2025
docs/src/real_world_example.rst
Outdated
| In total, we mix roughly :math:`30\mathrm{mg}` of TPO into :math:`40\mathrm{mL}` of the resin. | ||
| With a spectrometer, we determine the absorbance at our printing wavelength :math:`405\mathrm{nm}` to be :math:`A=0.2347/1\mathrm{cm}`. That means, :math:`\mu = 54.04\mathrm{m}^{-1}`- | ||
| With a spectrometer, we determine the absorbance at our printing wavelength :math:`405\mathrm{nm}` to be :math:`A=0.2347/1\mathrm{cm}`. That means, :math:`\mu = 2.302\cdot A \approx 0.5404\mathrm{cm}^{-1}`- |
There was a problem hiding this comment.
Lets write it as log(10) * 10
There was a problem hiding this comment.
Sure, I'll switch it to ln(10)
edit: made a mistake with the unit conversion
There was a problem hiding this comment.
We can keep per /cm. In the config.json everything is in /mm.
So maybe we also convert it also to per mm. Then it should be clear.
|
Thanks a lot :)! Also, if you need more help to get it run, do not hesitate to give me a call! |
|
Thanks, I'll merge. Should be updated soon in the online docs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IOR in the text and code didn't match. Also made the conversion from A to µ explicit.