feat: use archives for downloading GH templates #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uses the new functionality added in jaredallard/vcs@v0.3.0 to support downloading templates using archives instead of git clone. This is a best-effort approach, if this fails then git clone will be falled back to.
Deploying stencil with
|
| Latest commit: |
d7edffd
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://4ac9a5ae.stencil-1wj.pages.dev |
| Branch Preview URL: | https://jaredallard-feat-vcs-use-arc.stencil-1wj.pages.dev |
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
deregtd
approved these changes
Dec 22, 2024
|
Going to hold off on this until jaredallard/vcs#30 lands so that we don't accidentally balloon token fetching time. This is because @deregtd notes that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses the new functionality added in jaredallard/vcs@v0.3.0 to support
downloading templates using archives instead of git clone. This is a
best-effort approach, if this fails then git clone will be falled back
to.